Jimexist commented on a change in pull request #571:
URL: https://github.com/apache/arrow-datafusion/pull/571#discussion_r657093937
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -265,9 +266,48 @@ impl DefaultPhysicalPlanner {
}
let input_exec = self.create_initial_plan(input, ctx_state)?;
- let physical_input_schema = input_exec.schema();
- let logical_input_schema = input.as_ref().schema();
+ // at this moment we are guaranteed by the logical planner
+ // to have all the window_expr to have equal sort key
Review comment:
i can add the assertion later. yes the invariant is real.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
