alamb commented on a change in pull request #571:
URL: https://github.com/apache/arrow-datafusion/pull/571#discussion_r657228310
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1452,11 +1452,18 @@ impl fmt::Debug for Expr {
}
Expr::WindowFunction {
fun,
- ref args,
+ args,
+ partition_by,
Review comment:
I see -- this makes sense. Thank you for the clarification
Perhaps it is worth a comment (in a follow on PR) on the `LogicalPlan`
window to this effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
