nealrichardson commented on a change in pull request #10547:
URL: https://github.com/apache/arrow/pull/10547#discussion_r657274423
##########
File path: r/R/dplyr-functions.R
##########
@@ -215,6 +215,52 @@ nse_funcs$nchar <- function(x, type = "chars", allowNA =
FALSE, keepNA = NA) {
}
}
+nse_funcs$paste <- function(..., sep = " ", collapse = NULL, recycle0 = FALSE)
{
+ assert_that(is.null(collapse))
Review comment:
Should we do better than this (i.e. explain in the error message that
Arrow doesn't support it currently)?
##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -21,6 +21,162 @@ skip_if_not_available("utf8proc")
library(dplyr)
library(stringr)
+test_that("paste, paste0, and str_c", {
+ df <- tibble(
+ v = c("α", "β", "γ"),
Review comment:
I would advise against putting UTF-8 in this test file and just trust
that the C++ library handles it correctly. Could just be outdated CRAN
paranoia, but I've definitely had checks fail on some platform where it
couldn't parse the test file because it had special characters in it (sounds
like a Solaris thing right?). See also test-utf.R
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
