houqp commented on a change in pull request #605:
URL: https://github.com/apache/arrow-datafusion/pull/605#discussion_r657376400
##########
File path: datafusion/src/logical_plan/dfschema.rs
##########
@@ -387,6 +402,9 @@ impl Display for DFSchema {
pub struct DFField {
/// Optional qualifier (usually a table or relation name)
qualifier: Option<String>,
+ /// Optional set of qualifiers that all share this same field. This is
used for `JOIN USING`
Review comment:
Yeah, this is the part I am not a fan about the current implementation,
a field having both shared_qualifiers and single qualifier should never happen.
An optional enum type on qualifier field would provide the correct semantic we
want to capture here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
