thisisnic commented on pull request #10598: URL: https://github.com/apache/arrow/pull/10598#issuecomment-868407701
> > * `fiscal_start` - this is an argument to `quarter` which indicates the starting month of a fiscal year - I think this would be useful to implement > > Is this just an arbitrary month user sets or is there a standard? The default value in `lubridate` is 1 (the calendar year quarter), and I think it would make sense for that to be the default unless otherwise specified. > I was wondering about locale as well. Would it be a good idea to be able to set an arbitrary locale in some cases? [Pandas appears not to offer this option](https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.dayofweek.html). It would be useful for strftime but could cause misinterpretations for say day_of_week. Again, I'd like input from others on this (I am not experienced in this and may be missing something!), but my initial thoughts are that if we do choose to extract the day of week and month as integers only (and not implement the `label` argument), then all the locale stuff can be handled by `strftime` in terms of converting it from an integer to a text representation, so the locale is not relevant to TemporalOptions specifically within the context of extracting components from datetime objects. > Added [strftime jira](https://issues.apache.org/jira/browse/ARROW-13174). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
