pachadotdev commented on a change in pull request #10613:
URL: https://github.com/apache/arrow/pull/10613#discussion_r660146504
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start =
getOption("lubridate.week.start", 7)) {
-
+
Review comment:
space
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start =
getOption("lubridate.week.start", 7)) {
-
+
# The "day_of_week" compute function returns numeric days of week and not
locale-aware strftime
# When the ticket below is resolved, we should be able to support the label
argument
# https://issues.apache.org/jira/browse/ARROW-13133
if (label) {
arrow_not_supported("Label argument")
}
-
+
# overall formula to convert from arrow::wday to lubridate::wday is:
# ((wday(day) - start + 8) %% 7) + 1
((Expression$create("day_of_week", x) - Expression$scalar(week_start) + 8)
%% 7) + 1
-
+
Review comment:
space
##########
File path: r/R/dplyr-functions.R
##########
@@ -519,16 +535,16 @@ nse_funcs$second <- function(x) {
# providing offset values based on the specified week_start day, and adding 1
# so the returned value is 1-indexed instead of 0-indexed.
nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start =
getOption("lubridate.week.start", 7)) {
-
+
# The "day_of_week" compute function returns numeric days of week and not
locale-aware strftime
# When the ticket below is resolved, we should be able to support the label
argument
# https://issues.apache.org/jira/browse/ARROW-13133
if (label) {
arrow_not_supported("Label argument")
}
-
+
Review comment:
space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
