lidavidm commented on a change in pull request #10586:
URL: https://github.com/apache/arrow/pull/10586#discussion_r659741038
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -2755,6 +2748,138 @@ Result<ValueDescr> StrptimeResolve(KernelContext* ctx,
const std::vector<ValueDe
return Status::Invalid("strptime does not provide default StrptimeOptions");
}
+// ----------------------------------------------------------------------
+// string padding
+
+template <bool PadLeft, bool PadRight>
Review comment:
It's not really for performance, just that it's most convenient to pass
them this way. Otherwise we'd need to create a subclass of
StringTransformExecWithState for each kernel to pass the parameters, which
would end up generating the same amount of code anyways. Or we could make them
actual function options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
