jorgecarleitao commented on a change in pull request #628:
URL: https://github.com/apache/arrow-datafusion/pull/628#discussion_r660897951
##########
File path: ballista/rust/core/src/serde/logical_plan/to_proto.rs
##########
@@ -1201,7 +1201,7 @@ impl TryInto<protobuf::LogicalExprNode> for &Expr {
Expr::Wildcard => Ok(protobuf::LogicalExprNode {
expr_type:
Some(protobuf::logical_expr_node::ExprType::Wildcard(true)),
}),
- Expr::TryCast { .. } => unimplemented!(),
+ _ => unimplemented!(),
Review comment:
@andygrove , this is not ideal; I have to admit I am not very familiar
with proto and this part yet. Could be relevant to add a small guide in the
readme like "how to add a new logical node to ballista"? It could reduce the
barrier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
