jpedroantunes commented on a change in pull request #10622:
URL: https://github.com/apache/arrow/pull/10622#discussion_r661055443
##########
File path: cpp/src/gandiva/precompiled/string_ops.cc
##########
@@ -1966,4 +1966,233 @@ const char* binary_string(gdv_int64 context, const
char* text, gdv_int32 text_le
*out_len = j;
return ret;
}
+
+FORCE_INLINE
+const char* parse_url_utf8_utf8(gdv_int64 context, const char* url, gdv_int64
url_len,
+ const char* part_to_extract, gdv_int64
part_len,
+ gdv_int32* out_len) {
+ if (url_len == 0) {
+ return nullptr;
+ }
+
+ auto protocol_key = "PROTOCOL";
Review comment:
Maybe we can check a way of not having to instantiate these variables
constantly.
##########
File path: cpp/src/gandiva/precompiled/string_ops_test.cc
##########
@@ -1540,4 +1540,72 @@ TEST(TestStringOps, TestConvertToBigEndian) {
}
#endif
}
+
Review comment:
Add prijector tests please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
