nevi-me opened a new pull request #511:
URL: https://github.com/apache/arrow-rs/pull/511
# Which issue does this PR close?
Closes #385.
# Rationale for this change
While investigating #385, I noticed that there was a discrepancy between the
max definitions calculated in `parquet::arrow::levels.` and what the parquet
type system emits. So I kept digging, and found that my interpretation of the
rules had errors.
- non-null primitive should have def = 0, was misinterpreting the spec
- list increments 1 if not null, or 2 if null
This fixes these issues, and updates the tests
# What changes are included in this PR?
Described above
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]