kszucs commented on a change in pull request #8824:
URL: https://github.com/apache/arrow/pull/8824#discussion_r661392557



##########
File path: .github/workflows/cpp.yml
##########
@@ -21,7 +21,7 @@ on:
   push:
     paths:
       - '.github/workflows/cpp.yml'
-      - 'ci/docker/**'
+      - 'ci/docker/*cpp*'

Review comment:
       Indeed, neither does docker nor docker-compose have an idea about the 
image hierarchy but archery does. 
   
   `archery build` and `archery run` commands are idempotent, meaning that the 
produced docker images are going to be the same for the same input 
configuration regardless of the state in the docker registry. 
   
   See the commands called underneath the `archery docker run` command:
   
   ```
   ❯ archery docker --dry-run run ubuntu-docs
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose pull --ignore-pull-failures 
ubuntu-cpp
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose pull --ignore-pull-failures 
ubuntu-python
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose pull --ignore-pull-failures 
ubuntu-docs
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose build --build-arg 
BUILDKIT_INLINE_CACHE=1 ubuntu-cpp
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose build --build-arg 
BUILDKIT_INLINE_CACHE=1 ubuntu-python
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose build --build-arg 
BUILDKIT_INLINE_CACHE=1 ubuntu-docs
   COMPOSE_DOCKER_CLI_BUILD=1 docker-compose run --rm ubuntu-docs
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to