kou commented on a change in pull request #10614:
URL: https://github.com/apache/arrow/pull/10614#discussion_r661808349
##########
File path: matlab/CMakeLists.txt
##########
@@ -72,3 +89,28 @@ else()
set_target_properties(featherwritemex PROPERTIES LIBRARY_OUTPUT_DIRECTORY
$<1:${CMAKE_SOURCE_DIR}/src>)
endif()
+
+# ######################
+# GoogleTest Integration
+# ######################
+# If the user has specified a GTEST_ROOT value, use their pre-built GoogleTest
binaries.
+# Otherwise, download and build GoogleTest automatically.
+if(GTEST_ROOT)
+ find_package(GTest REQUIRED)
+else()
+ download_and_build_google_test()
Review comment:
Can we clarify target people of the MATLAB library's test?
1. Users: People who use the MATLAB library.
2. Developers: People who develop the MATLAB library.
3. Both of 1. and 2.
My thought is 2.
For 2., custom Apache Arrow C++ build is useful. For example, developers may
want to build with `-DCMAKE_BUILD_TYPE=debug` for debugging and with
`-DCMAKE_BUILD_TYPE=release` for benchmarking.
So, it may be reasonable that developers build Apache Arrow C++ manually.
For 1., users may not want to enable tests by default. Because they just
want to use the MATLAB library.
If you still want to implement automatic Apache Arrow C++ build in CMake,
I'll take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
