jorisvandenbossche commented on a change in pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#discussion_r662147383
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -216,6 +216,19 @@ struct ARROW_EXPORT ProjectOptions : public
FunctionOptions {
std::vector<std::shared_ptr<const KeyValueMetadata>> field_metadata;
};
+struct ARROW_EXPORT DayOfWeekOptions : public FunctionOptions {
+ explicit DayOfWeekOptions(bool one_based_numbering, uint32_t week_start)
+ : one_based_numbering(one_based_numbering), week_start(week_start) {}
Review comment:
I suppose the Option construction cannot raise an error, since it
doesn't return a Result or Status. But we should certainly not silently
truncate the value passed by the user.
Is there another place where this can be validated in the C++ kernel
machinery? For example in the kernel's `Exec` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
