bkietz commented on a change in pull request #10632:
URL: https://github.com/apache/arrow/pull/10632#discussion_r662208272
##########
File path: cpp/src/arrow/compute/exec/expression_test.cc
##########
@@ -522,7 +522,7 @@ TEST(Expression, BindNestedCall) {
TEST(Expression, ExecuteFieldRef) {
auto ExpectRefIs = [](FieldRef ref, Datum in, Datum expected) {
- auto expr = field_ref(ref);
+ auto expr = field_ref(std::move(ref));
Review comment:
This is fine, but I think it's acceptable to be sloppier with moves in
tests because it makes debugging easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
