[GitHub] [arrow] n3world commented on a change in pull request #10649: ARROW-13246: [C++] Set partial to remainder of buffer

Fri, 02 Jul 2021 12:02:23 -0700 


n3world commented on a change in pull request #10649:
URL: https://github.com/apache/arrow/pull/10649#discussion_r663200183



##########
File path: cpp/src/arrow/csv/reader.cc
##########
@@ -307,7 +309,7 @@ class ThreadedBlockReader : public BlockReader {
       RETURN_NOT_OK(chunker_->ProcessSkip(current_partial, current_buffer, 
is_final,
                                           &skip_rows_, &current_buffer));
       bytes_skipped += orig_size - current_buffer->size();
-      current_partial = SliceBuffer(current_buffer, 0, 0);
+      current_partial = std::make_shared<Buffer>(nullptr, 0);

Review comment:
       No because in the block right below this `partial_` is correctly set 
`partial_ = std::move(current_buffer);`. The bug only was in the serial reader.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to