westonpace commented on a change in pull request #10628:
URL: https://github.com/apache/arrow/pull/10628#discussion_r663271279
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -3095,10 +3104,24 @@ def test_write_dataset_use_threads(tempdir):
pa.schema([("part", pa.string())]), flavor="hive")
target1 = tempdir / 'partitioned1'
+ paths_written = []
+
+ def file_visitor(written_file):
+ paths_written.append(written_file.path)
+
ds.write_dataset(
dataset, target1, format="feather", partitioning=partitioning,
- use_threads=True
+ use_threads=True, file_visitor=file_visitor
)
+ expected_paths = [
+ target1 / 'part=a' / 'part-0.feather',
+ target1 / 'part=a' / 'part-1.feather',
+ target1 / 'part=b' / 'part-0.feather',
+ target1 / 'part=b' / 'part-1.feather'
+ ]
+ for path in paths_written:
+ assert pathlib.Path(path) in expected_paths
Review comment:
That was intentional. Only two paths are written but I don't know if
part-0.feather goes in part=a or part=b (since it is multithreaded). I refined
the check to be a little clearer and added a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
