alamb commented on a change in pull request #657:
URL: https://github.com/apache/arrow-datafusion/pull/657#discussion_r663849500
##########
File path: datafusion/src/physical_plan/parquet.rs
##########
@@ -72,6 +76,8 @@ pub struct ParquetExec {
batch_size: usize,
/// Statistics for the data set (sum of statistics for all partitions)
statistics: Statistics,
+ /// Numer of times the pruning predicate could not be created
+ predicate_creation_errors: Arc<SQLMetric>,
Review comment:
The reason I didn't do this is because the other metrics are per
`ParquetPartition` (aka per each file / set of files) but this one is just one
metric for the overall `ParquetExec`
I agree this is confusing -- I'll make two statistics structures
(`ParquetPartitionMetrics` and `ParquetMetrics`) which hopefully will make this
clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
