projjal commented on a change in pull request #10604:
URL: https://github.com/apache/arrow/pull/10604#discussion_r664860448
##########
File path: cpp/src/gandiva/gdv_function_stubs_test.cc
##########
@@ -514,7 +514,31 @@ TEST(TestGdvFnStubs, TestInitCap) {
EXPECT_FALSE(ctx.has_error());
out_str = gdv_fn_initcap_utf8(ctx_ptr, "{ÕHP,pqśv}Ń+", 15, &out_len);
- EXPECT_EQ(std::string(out_str, out_len), "{ÕHP,pqśv}Ń+");
+ EXPECT_EQ(std::string(out_str, out_len), "{Õhp,Pqśv}Ń+");
+ EXPECT_FALSE(ctx.has_error());
+
+ out_str = gdv_fn_initcap_utf8(ctx_ptr, "sɦasasdsɦsd\"sdsdɦ", 19, &out_len);
+ EXPECT_EQ(std::string(out_str, out_len), "Sɦasasdsɦsd\"Sdsdɦ");
+ EXPECT_FALSE(ctx.has_error());
+
+ out_str = gdv_fn_initcap_utf8(ctx_ptr, "mysuperscipt@number²isfine", 27,
&out_len);
+ EXPECT_EQ(std::string(out_str, out_len), "Mysuperscipt@Number²Isfine");
+ EXPECT_FALSE(ctx.has_error());
+
+ out_str = gdv_fn_initcap_utf8(ctx_ptr, "Ő<tŵas̓老ƕɱ¢vIYwށ", 25, &out_len);
+ EXPECT_EQ(std::string(out_str, out_len), "Ő<Tŵas̓老Ƕɱ¢Viywށ");
Review comment:
Also looks v is captialised. Is ¢ treated as space character?
Btw since we are keeping the behaviour same as oracle, did you make sure to
match these expected values in unittests by running them on oracle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
