ianmcook commented on a change in pull request #10638:
URL: https://github.com/apache/arrow/pull/10638#discussion_r664867533
##########
File path: r/R/dplyr-functions.R
##########
@@ -414,6 +414,25 @@ nse_funcs$pmax <- function(..., na.rm = FALSE) {
)
}
+nse_funcs$str_pad <- function(string, width, side = c("left", "right",
"both"), pad = " ") {
+
+ side <- match.arg(side)
Review comment:
I think this is important because `stringr::str_pad()` can take vector
`width` and `pad` and recycle them, but that will not work here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
