bkietz commented on a change in pull request #10628:
URL: https://github.com/apache/arrow/pull/10628#discussion_r665440409
##########
File path: python/pyarrow/parquet.py
##########
@@ -1958,8 +1958,11 @@ def write_to_dataset(table, root_path,
partition_cols=None,
"implementation."
)
metadata_collector = kwargs.pop('metadata_collector', None)
+ file_visitor = None
if metadata_collector is not None:
- raise ValueError(msg.format("metadata_collector"))
+ def file_visitor(written_file):
+ if written_file.metadata:
Review comment:
It could instead be an `assert`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
