kevingurney commented on a change in pull request #10614:
URL: https://github.com/apache/arrow/pull/10614#discussion_r666492483
##########
File path: matlab/CMakeLists.txt
##########
@@ -17,6 +17,84 @@
cmake_minimum_required(VERSION 3.20)
+# Build the Arrow C++ libraries WITHOUT bundled GoogleTest binaries.
+function(BUILD_ARROW)
Review comment:
Thanks - this is a really good idea!
We factored out the GoogleTest-specific logic into a macro called
`build_gtest` for code cleanliness and added a `BUILD_GTEST` argument to
`build_arrow` in order to enable us to remove the `build_arrow_and_gtest`
function. `build_arrow` now just calls `build_gtest` when `BUILD_GTEST` is
supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
