eerhardt commented on a change in pull request #10527:
URL: https://github.com/apache/arrow/pull/10527#discussion_r666503779
##########
File path: csharp/src/Apache.Arrow/Ipc/ArrowStreamWriter.cs
##########
@@ -248,6 +263,13 @@ private protected void
WriteRecordBatchInternal(RecordBatch recordBatch)
HasWrittenSchema = true;
}
+ if (!HasWrittenDictionaryBatch)
+ {
+ DictionaryCollector.Collect(recordBatch, ref _dictionaryMemo);
Review comment:
Can you run the benchmark tests before and after this change to see what
kind of impact this `DictionaryCollector` has when there are no dictionaries in
the batch? Hopefully it isn't much, but I'd like to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
