shanhuuang commented on pull request #10627: URL: https://github.com/apache/arrow/pull/10627#issuecomment-877139663
> > > Is it possible for delta_bit_width_<=32? if so it seems like we should probably cover that case while updating? > > > > > > In current code, internal::unpack32 is called in BitReader::GetBatch if delta_bit_width_<=32 whether value type is int64 or int32. > > delta_binary_packed.parquet contains int64 columns with delta_bit_width_ from 0 to 32 > > Sorry I think i mean >= 32? Yes, it is possible for delta_bit_width_>32. For example, a column contains records like 0, -4294967296, -860510501 The deltas would be -4294967296 and 3434456795 The minimum delta is -4294967296 so the final deltas are 0 and 7729424091 delta_bit_width_ of bit packed int(7729424091) is 33 delta_binary_packed.parquet also contains int64 columns with delta_bit_width_ from 33 to 64. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
