houqp commented on a change in pull request #605: URL: https://github.com/apache/arrow-datafusion/pull/605#discussion_r667379802
########## File path: datafusion/src/logical_plan/plan.rs ########## @@ -354,6 +356,43 @@ impl LogicalPlan { | LogicalPlan::CreateExternalTable { .. } => vec![], } } + + /// returns all `Using` join columns in a logical plan + pub fn using_columns(&self) -> Result<Vec<HashSet<Column>>, DataFusionError> { Review comment: @alamb this is used outside of the optimizers as well, for example, the logical plan builder. With that context, do you still think it should live in optimizer utils module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org