alamb commented on issue #461: URL: https://github.com/apache/arrow-rs/issues/461#issuecomment-877783516
> Wouldn't it make it more sense to add this to compute as a normal function? Implementing it on the RecordBatch interface is breaking the separation between compute and data that we enforce with the compute module. @jorgecarleitao I think that comes down to "is concat a construction operation or a compute operation"? It could probably be classified as either. I don't have a strong opinion about where the "concat RecordBatch" function goes. The only other prior art of using `RecordBatch`es in compute kernels I found is `pub fn filter_record_batch` in filter.rs ` https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/filter.rs#L279-L298 We could perhaps add a `concat_batches` function in compute/kernels/concat.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
