alamb commented on a change in pull request #532:
URL: https://github.com/apache/arrow-rs/pull/532#discussion_r667468941
##########
File path: .github/workflows/rust.yml
##########
@@ -357,15 +353,22 @@ jobs:
uses: actions/cache@v2
with:
path: /github/home/target
- key: ${{ runner.os }}-${{ matrix.arch }}-target-wasm32-cache-${{
matrix.rust }}
+ # this key equals the ones on `linux-build-lib` for re-use
+ key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{
matrix.rust }}
- name: Setup Rust toolchain
run: |
rustup toolchain install ${{ matrix.rust }}
rustup override set ${{ matrix.rust }}
rustup component add rustfmt
- - name: Build arrow crate
+ - name: Build with default features
run: |
export CARGO_HOME="/github/home/.cargo"
export CARGO_TARGET_DIR="/github/home/target"
- cd arrow
- cargo check --all-targets --no-default-features
Review comment:
I think the reason CI isn't catching issues with feature flags is due to
the cargo semantics of a `workspace` -- where Cargo tries to calculate the
dependency needs of the workspace as a whole. Since we have some crates in the
workspace (like `arrow-flight`) that bring in additional dependencies, these
additional dependencies can obscure build problems with other crates (like
`arrow`) when used alone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
