andygrove opened a new pull request #706:
URL: https://github.com/apache/arrow-datafusion/pull/706
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #685 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
We originally used the `concurrency` config setting to determine how many
threads to launch in certain parts of the code base but we now use Tokio to
manage task concurrency. The `concurrency` setting is only used to determine
the number of partitions to use when repartitioning the plan. We should
therefore rename this config setting.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Introduce new `with_default_partitions` method and leave `with_concurrency`
in place for now so that we don't break the API.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
If users were accessing the `concurrency` field in `ExecutionContext` then
they will now need to use `default_partitions` instead. Users should not be
accessing these attributes directly though.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
