lidavidm commented on a change in pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#discussion_r668138827
##########
File path: r/src/arrowExports.cpp
##########
@@ -1807,10 +1807,10 @@ extern "C" SEXP
_arrow_dataset___IpcFileWriteOptions__update1(SEXP ipc_options_s
// dataset.cpp
#if defined(ARROW_R_WITH_DATASET)
-void dataset___CsvFileWriteOptions__update(const
std::shared_ptr<ds::CsvFileWriteOptions>& csv_options, const
std::shared_ptr<arrow::csv::WriteOptions>& write_options);
+void dataset___CsvFileWriteOptions__update(const
std::shared_ptr<arrow::ds::CsvFileWriteOptions>& csv_options, const
std::shared_ptr<arrow::csv::WriteOptions>& write_options);
extern "C" SEXP _arrow_dataset___CsvFileWriteOptions__update(SEXP
csv_options_sexp, SEXP write_options_sexp){
BEGIN_CPP11
- arrow::r::Input<const std::shared_ptr<ds::CsvFileWriteOptions>&>::type
csv_options(csv_options_sexp);
+ arrow::r::Input<const
std::shared_ptr<arrow::ds::CsvFileWriteOptions>&>::type
csv_options(csv_options_sexp);
Review comment:
These changes seem bad - it should be arrow::dataset:: or just ds::.
##########
File path: r/src/arrow_types.h
##########
@@ -37,6 +37,7 @@
#include <arrow/csv/type_fwd.h>
#if defined(ARROW_R_WITH_DATASET)
+#include <arrow/dataset/file_csv.h>
Review comment:
dataset/type_fwd.h already defines arrow::dataset::CsvFileWriteOptions,
so it's unclear why this is needed…
##########
File path: r/src/csv.cpp
##########
@@ -191,15 +191,15 @@ std::shared_ptr<arrow::TimestampParser>
TimestampParser__MakeISO8601() {
void csv___WriteCSV__Table(const std::shared_ptr<arrow::Table>& table,
const std::shared_ptr<arrow::csv::WriteOptions>&
write_options,
const std::shared_ptr<arrow::io::OutputStream>&
stream) {
- StopIfNotOk(arrow::csv::WriteCSV(*table, *write_options, stream.get()));
+ arrow::StopIfNotOk(arrow::csv::WriteCSV(*table, *write_options,
stream.get()));
Review comment:
Similarly, other files and other builds are all OK with this - so what
gives here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
