nirandaperera commented on pull request #10679:
URL: https://github.com/apache/arrow/pull/10679#issuecomment-878573510
I tested with a `VisitWords` impl for this. And it seems to have better
results.
```
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Non-regressions: (11)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline contender change %
counters
FilterInt64FilterNoNulls/1048576/4 1.421 GiB/sec 2.958 GiB/sec 108.167
{'run_name': 'FilterInt64FilterNoNulls/1048576/4', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 1019, 'data null%': 0.1,
'mask null%': 0.0, 'select%': 50.0}
FilterInt64FilterNoNulls/1048576/13 1.318 GiB/sec 2.708 GiB/sec 105.439
{'run_name': 'FilterInt64FilterNoNulls/1048576/13', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 945, 'data null%': 90.0,
'mask null%': 0.0, 'select%': 50.0}
FilterInt64FilterNoNulls/1048576/10 1.318 GiB/sec 2.704 GiB/sec 105.207
{'run_name': 'FilterInt64FilterNoNulls/1048576/10', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 944, 'data null%': 10.0,
'mask null%': 0.0, 'select%': 50.0}
FilterInt64FilterNoNulls/1048576/7 1.364 GiB/sec 2.754 GiB/sec 101.937
{'run_name': 'FilterInt64FilterNoNulls/1048576/7', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 977, 'data null%': 1.0,
'mask null%': 0.0, 'select%': 50.0}
FilterInt64FilterNoNulls/1048576/1 2.353 GiB/sec 2.621 GiB/sec 11.389
{'run_name': 'FilterInt64FilterNoNulls/1048576/1', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 1689, 'data null%': 0.0,
'mask null%': 0.0, 'select%': 50.0}
FilterInt64FilterNoNulls/1048576/12 6.524 GiB/sec 7.231 GiB/sec 10.830
{'run_name': 'FilterInt64FilterNoNulls/1048576/12', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 4783, 'data null%': 90.0,
'mask null%': 0.0, 'select%': 99.9}
FilterInt64FilterNoNulls/1048576/2 39.394 GiB/sec 42.267 GiB/sec 7.293
{'run_name': 'FilterInt64FilterNoNulls/1048576/2', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 28183, 'data null%': 0.0,
'mask null%': 0.0, 'select%': 1.0}
FilterInt64FilterNoNulls/1048576/9 6.925 GiB/sec 7.207 GiB/sec 4.077
{'run_name': 'FilterInt64FilterNoNulls/1048576/9', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 4905, 'data null%': 10.0,
'mask null%': 0.0, 'select%': 99.9}
FilterInt64FilterNoNulls/1048576/6 7.873 GiB/sec 8.009 GiB/sec 1.730
{'run_name': 'FilterInt64FilterNoNulls/1048576/6', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 5643, 'data null%': 1.0,
'mask null%': 0.0, 'select%': 99.9}
FilterInt64FilterNoNulls/1048576/3 9.167 GiB/sec 9.225 GiB/sec 0.637
{'run_name': 'FilterInt64FilterNoNulls/1048576/3', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 6530, 'data null%': 0.1,
'mask null%': 0.0, 'select%': 99.9}
FilterInt64FilterNoNulls/1048576/0 13.827 GiB/sec 13.744 GiB/sec -0.597
{'run_name': 'FilterInt64FilterNoNulls/1048576/0', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 9834, 'data null%': 0.0,
'mask null%': 0.0, 'select%': 99.9}
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Regressions: (4)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline contender change %
counters
FilterInt64FilterNoNulls/1048576/5 10.049 GiB/sec 5.493 GiB/sec -45.344
{'run_name': 'FilterInt64FilterNoNulls/1048576/5', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 7199, 'data null%': 0.1,
'mask null%': 0.0, 'select%': 1.0}
FilterInt64FilterNoNulls/1048576/8 9.571 GiB/sec 5.223 GiB/sec -45.423
{'run_name': 'FilterInt64FilterNoNulls/1048576/8', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 6869, 'data null%': 1.0,
'mask null%': 0.0, 'select%': 1.0}
FilterInt64FilterNoNulls/1048576/11 9.494 GiB/sec 5.073 GiB/sec -46.560
{'run_name': 'FilterInt64FilterNoNulls/1048576/11', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 6836, 'data null%': 10.0,
'mask null%': 0.0, 'select%': 1.0}
FilterInt64FilterNoNulls/1048576/14 9.517 GiB/sec 5.075 GiB/sec -46.674
{'run_name': 'FilterInt64FilterNoNulls/1048576/14', 'repetitions': 0,
'repetition_index': 0, 'threads': 1, 'iterations': 6829, 'data null%': 90.0,
'mask null%': 0.0, 'select%': 1.0}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
