jpedroantunes commented on a change in pull request #10465: URL: https://github.com/apache/arrow/pull/10465#discussion_r668350635
########## File path: cpp/src/gandiva/greedy_dual_size_cache.h ########## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <list> +#include <queue> +#include <set> +#include <unordered_map> +#include <utility> + +#include "arrow/util/optional.h" + +// modified cache to support evict policy using the GreedyDual-Size algorithm. +namespace gandiva { +// Defines a base value object supported on the cache that may contain properties +template <typename ValueType> +class ValueCacheObject { + public: + ValueCacheObject(ValueType module, uint64_t cost) : module(module), cost(cost) {} + ValueCacheObject() = default; Review comment: I removed it, but it is important to notice that just removing it breaks the code, since the Cache implementation was fulfilling the map like this `map_[key] = std::make_pair(value_cache_object, iter.first);` using the operator `[]`. The **operator []** uses the default constructor. Because of that, I changed to use the `emplace` function when adding an item to the map. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
