jonkeane commented on a change in pull request #10706:
URL: https://github.com/apache/arrow/pull/10706#discussion_r668820854



##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -70,30 +70,51 @@ verify_output <- function(...) {
   testthat::verify_output(...)
 }
 
-expect_dplyr_equal <- function(expr, # A dplyr pipeline with `input` as its 
start
-                               tbl,  # A tbl/df as reference, will make 
RB/Table with
-                               skip_record_batch = NULL, # Msg, if should skip 
RB test
-                               skip_table = NULL,        # Msg, if should skip 
Table test
+#' @param expr A dplyr pipeline with `input` as its start
+#' @param tbl A tbl/df as reference, will make RB/Table with
+#' @param skip_record_batch string skip message, if should skip RB test
+#' @param skip_table string skip message, if should skip Table test
+#' @param warning string expected warning from the RecordBatch and Table paths,
+#'   passed to `expect_warning()` Default is `NA`, for no warning message.
+#'   `TRUE` is a special case to mean to check for the
+#'   "not supported in Arrow; pulling data into R" message.

Review comment:
       ```suggestion
   #' @param warning string expected warning from the RecordBatch and Table 
paths,
   #'   passed to `expect_warning()`. Special values:
   #'     * `NA` (the default) for ensuring no warning message
   #'     * `TRUE` is a special case to mean to check for the
   #'      "not supported in Arrow; pulling data into R" message.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to