projjal commented on a change in pull request #10604:
URL: https://github.com/apache/arrow/pull/10604#discussion_r669015923
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -427,7 +427,8 @@ CAST_VARLEN_TYPE_FROM_NUMERIC(VARBINARY)
#undef GDV_FN_CAST_VARCHAR_REAL
GANDIVA_EXPORT
-int32_t gdv_fn_utf8_char_length(char c) {
+FORCE_INLINE
Review comment:
I think add a separate macro in this file
```
#if defined(_MSC_VER)
#define GDV_FORCE_INLINE __forceinline
#else
#define GDV_FORCE_INLINE inline __attribute__((always_inline))
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
