nirandaperera commented on a change in pull request #10412: URL: https://github.com/apache/arrow/pull/10412#discussion_r669031884
########## File path: cpp/src/arrow/compute/kernels/vector_replace.cc ########## @@ -0,0 +1,510 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/api_scalar.h" +#include "arrow/compute/kernels/common.h" +#include "arrow/util/bitmap_ops.h" + +namespace arrow { +namespace compute { +namespace internal { + +namespace { + +Status ReplacementArrayTooShort(int64_t expected, int64_t actual) { + return Status::Invalid("Replacement array must be of appropriate length (expected ", + expected, " items but got ", actual, " items)"); +} + +// Helper to implement replace_with kernel with scalar mask for fixed-width types, +// using callbacks to handle both bool and byte-sized types +Status ReplaceWithScalarMask(KernelContext* ctx, const ArrayData& array, + const BooleanScalar& mask, const Datum& replacements, + ArrayData* output) { + if (!mask.is_valid) { + // Output = null + ARROW_ASSIGN_OR_RAISE(auto replacement_array, + MakeArrayOfNull(array.type, array.length, ctx->memory_pool())); + *output = *replacement_array->data(); + return Status::OK(); + } + if (mask.value) { + // Output = replacement + if (replacements.is_scalar()) { + ARROW_ASSIGN_OR_RAISE( + auto replacement_array, + MakeArrayFromScalar(*replacements.scalar(), array.length, ctx->memory_pool())); + *output = *replacement_array->data(); + } else { + auto replacement_array = replacements.array(); + if (replacement_array->length != array.length) { + return ReplacementArrayTooShort(array.length, replacement_array->length); + } + *output = *replacement_array; + } + } else { + // Output = input + *output = array; + } + return Status::OK(); +} + +struct CopyArrayBitmap { + const uint8_t* in_bitmap; + int64_t in_offset; + + void CopyBitmap(uint8_t* out_bitmap, int64_t out_offset, int64_t offset, + int64_t length) const { + arrow::internal::CopyBitmap(in_bitmap, in_offset + offset, length, out_bitmap, + out_offset); + } + + void SetBit(uint8_t* out_bitmap, int64_t out_offset, int64_t offset) const { + BitUtil::SetBitTo(out_bitmap, out_offset, + BitUtil::GetBit(in_bitmap, in_offset + offset)); + } +}; + +struct CopyScalarBitmap { + const bool is_valid; + + void CopyBitmap(uint8_t* out_bitmap, int64_t out_offset, int64_t offset, + int64_t length) const { + BitUtil::SetBitsTo(out_bitmap, out_offset, length, is_valid); + } + + void SetBit(uint8_t* out_bitmap, int64_t out_offset, int64_t offset) const { + BitUtil::SetBitTo(out_bitmap, out_offset, is_valid); + } +}; + +// Helper to implement replace_with kernel with array mask for fixed-width types, +// using callbacks to handle both bool and byte-sized types and to handle +// scalar and array replacements +template <typename Functor, typename Data, typename CopyBitmap> +void ReplaceWithArrayMaskImpl(const ArrayData& array, const ArrayData& mask, + const Data& replacements, bool replacements_bitmap, + const CopyBitmap copy_bitmap, const uint8_t* mask_bitmap, Review comment: interesting :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
