lidavidm commented on pull request #10557: URL: https://github.com/apache/arrow/pull/10557#issuecomment-879363403
Fixed docstrings and fixed a TODO I noticed about fully initializing the output buffer. Also added a benchmark case for when both the cond struct array and the child cond boolean arrays can have nulls. This case is especially terrible, I made a slight optimization to eliminate one of the more egregious offenders I saw in perf, but it's still bad even then: ``` ----------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... ----------------------------------------------------------------------------------------------- CaseWhenBench64/1048576/0 6045379 ns 6045204 ns 125 bytes_per_second=1.29235G/s CaseWhenBench64/1048576/99 6106510 ns 6106346 ns 123 bytes_per_second=1.27929G/s CaseWhenBench64OuterNulls/1048576/0 32735686 ns 32733991 ns 23 bytes_per_second=244.394M/s CaseWhenBench64OuterNulls/1048576/99 34098317 ns 34097473 ns 21 bytes_per_second=234.599M/s CaseWhenBench64Contiguous/1048576/0 2229728 ns 2229687 ns 338 bytes_per_second=3.50386G/s CaseWhenBench64Contiguous/1048576/99 2456084 ns 2456085 ns 237 bytes_per_second=3.18058G/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
