domoritz commented on a change in pull request #10698:
URL: https://github.com/apache/arrow/pull/10698#discussion_r670105369
##########
File path: js/gulp/package-task.js
##########
@@ -46,14 +46,19 @@ const createMainPackageJson = (target, format) => (orig) =>
({
...createTypeScriptPackageJson(target, format)(orig),
bin: orig.bin,
name: npmPkgName,
- main: `${mainExport}.node`,
- browser: `${mainExport}.dom`,
- module: `${mainExport}.dom.mjs`,
+ type: 'commonjs',
+ main: `${mainExport}.node.js`,
+ module: `${mainExport}.dom.js`,
Review comment:
```suggestion
module: `${mainExport}.node.mjs`,
```
To be consistent with
https://github.com/apache/arrow/pull/10698/files#diff-9ad0361c0b3692cb897f0641d786ade504a91c8c1d6a36c3abd3cf33224946a0R96
we should use node. Also, don't we need the .mjs file here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
