thisisnic commented on pull request #10647: URL: https://github.com/apache/arrow/pull/10647#issuecomment-880657927
> > Naive question: how does strftime return the correct local-specific time when using the format that outputs days of week? I see that in the base R implementation of strftime, it's not a parameter that's passed in; is this something that here is detected by the vendored date libraries that we're using? > > Good question! I've tried adding a locale parameter to `StrftimeOptions` to be able to choose locale but locale instantiation was slightly different for different OS-es so I've opted to take it out of scope. I've not properly tested but I believe you will currently get the result in your systems locale. > > I would like to add the locale parameter to this but it might be good to tackle it in a separate PR. I'm open to adding it here too though. Thanks, that's useful to know! I don't think anyone is planning on doing ARROW-13133 ahead of the upcoming release, so no great urgency to do it in this PR, as long as there's a ticket created for implementing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
