bkietz commented on a change in pull request #10636:
URL: https://github.com/apache/arrow/pull/10636#discussion_r670775558
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -877,22 +878,26 @@ Result<std::shared_ptr<DatasetFactory>>
ParquetDatasetFactory::Make(
// Insert the path, or increase the count of row groups. It will be
assumed that the
// RowGroup of a file are ordered exactly as in the metadata file.
- auto row_groups = &path_to_row_group_ids.insert({std::move(path),
{}}).first->second;
- row_groups->emplace_back(i);
+ auto inserted_index =
+ paths_to_index.insert({std::move(path),
paths_with_row_group_ids.size()});
Review comment:
MSVC conversion error/warning:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/39995447/job/ldrjvpe3c7sr5sor#L1153
```suggestion
auto inserted_index =
paths_to_index.emplace(std::move(path),
static_cast<int>(paths_with_row_group_ids.size()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
