bkietz commented on a change in pull request #10725:
URL: https://github.com/apache/arrow/pull/10725#discussion_r670777575
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
##########
@@ -59,13 +59,22 @@ struct SumImpl : public ScalarAggregator {
using OutputType = typename TypeTraits<SumType>::ScalarType;
Status Consume(KernelContext*, const ExecBatch& batch) override {
- const auto& data = batch[0].array();
- this->count = data->length - data->GetNullCount();
- if (is_boolean_type<ArrowType>::value) {
- this->sum += static_cast<typename
SumType::c_type>(BooleanArray(data).true_count());
+ if (batch[0].is_array()) {
+ const auto& data = batch[0].array();
+ this->count = data->length - data->GetNullCount();
+ if (is_boolean_type<ArrowType>::value) {
+ this->sum +=
+ static_cast<typename
SumType::c_type>(BooleanArray(data).true_count());
+ } else {
+ this->sum +=
+ arrow::compute::detail::SumArray<CType, typename
SumType::c_type>(*data);
+ }
} else {
- this->sum +=
- arrow::compute::detail::SumArray<CType, typename
SumType::c_type>(*data);
+ const auto& data = *batch[0].scalar();
+ this->count = data.is_valid;
+ if (data.is_valid) {
+ this->sum += internal::UnboxScalar<ArrowType>::Unbox(data);
Review comment:
```suggestion
this->sum += internal::UnboxScalar<ArrowType>::Unbox(data) *
batch.length;
```
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
##########
@@ -59,13 +59,22 @@ struct SumImpl : public ScalarAggregator {
using OutputType = typename TypeTraits<SumType>::ScalarType;
Status Consume(KernelContext*, const ExecBatch& batch) override {
- const auto& data = batch[0].array();
- this->count = data->length - data->GetNullCount();
- if (is_boolean_type<ArrowType>::value) {
- this->sum += static_cast<typename
SumType::c_type>(BooleanArray(data).true_count());
+ if (batch[0].is_array()) {
+ const auto& data = batch[0].array();
+ this->count = data->length - data->GetNullCount();
+ if (is_boolean_type<ArrowType>::value) {
+ this->sum +=
+ static_cast<typename
SumType::c_type>(BooleanArray(data).true_count());
+ } else {
+ this->sum +=
+ arrow::compute::detail::SumArray<CType, typename
SumType::c_type>(*data);
+ }
} else {
- this->sum +=
- arrow::compute::detail::SumArray<CType, typename
SumType::c_type>(*data);
+ const auto& data = *batch[0].scalar();
+ this->count = data.is_valid;
Review comment:
```suggestion
this->count += data.is_valid * batch.length;
```
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
##########
@@ -59,13 +59,22 @@ struct SumImpl : public ScalarAggregator {
using OutputType = typename TypeTraits<SumType>::ScalarType;
Status Consume(KernelContext*, const ExecBatch& batch) override {
- const auto& data = batch[0].array();
- this->count = data->length - data->GetNullCount();
- if (is_boolean_type<ArrowType>::value) {
- this->sum += static_cast<typename
SumType::c_type>(BooleanArray(data).true_count());
+ if (batch[0].is_array()) {
+ const auto& data = batch[0].array();
+ this->count = data->length - data->GetNullCount();
Review comment:
```suggestion
this->count += data->length - data->GetNullCount();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
