nirandaperera commented on a change in pull request #10538:
URL: https://github.com/apache/arrow/pull/10538#discussion_r670798383
##########
File path: cpp/src/arrow/compute/kernels/scalar_if_else.cc
##########
@@ -893,6 +1031,21 @@ void AddBinaryIfElseKernels(const
std::shared_ptr<IfElseFunction>& scalar_functi
}
}
+void AddFSBinaryIfElseKernel(const std::shared_ptr<IfElseFunction>&
scalar_function) {
+ // cond array needs to be boolean always
+ ScalarKernel kernel(
+ {boolean(), InputType(Type::FIXED_SIZE_BINARY),
InputType(Type::FIXED_SIZE_BINARY)},
+ OutputType([](KernelContext*, const std::vector<ValueDescr>& descrs) {
+ return ValueDescr(descrs[1].type, ValueDescr::ANY);
+ }),
Review comment:
I think this needs to be checked! thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
