augustoasilva commented on a change in pull request #10711:
URL: https://github.com/apache/arrow/pull/10711#discussion_r671549496
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -767,6 +769,113 @@ const char* gdv_fn_initcap_utf8(int64_t context, const
char* data, int32_t data_
}
}
+GANDIVA_EXPORT
+const char* gdv_fn_from_unixtime_int64(int64_t context, gdv_timestamp in,
+ int32_t* out_len) {
+ const char* pattern = "yyyy-MM-dd hh:mm:ss";
+ const int length = strlen(pattern);
Review comment:
It make senses, I will apply your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
