[GitHub] [arrow] kou commented on a change in pull request #10736: ARROW-13360: [C++] Missing dependencies in cpp thirdparty offline dependencies versions.txt

[GitBox]

kou commented on a change in pull request #10736:
URL: https://github.com/apache/arrow/pull/10736#discussion_r671743703



##########
File path: cpp/thirdparty/versions.txt
##########
@@ -64,6 +64,9 @@ ARROW_ZSTD_BUILD_VERSION=v1.4.8
 # given version.
 DEPENDENCIES=(
   "ARROW_ABSL_URL absl-${ARROW_ABSL_BUILD_VERSION}.tar.gz 
https://github.com/abseil/abseil-cpp/archive/${ARROW_ABSL_BUILD_VERSION}.tar.gz";
+  "ARROW_AWS_C_COMMON_URL 
aws-c-common-${ARROW_AWS_C_COMMON_BUILD_VERSION}.tar.gz 
https://github.com/awslabs/aws-c-common/archive/${ARROW_AWS_C_COMMON_BUILD_VERSION}.tar.gz";
+  "ARROW_AWS_CHECKSUMS_URL aws-checksums-${ARROW_AWS_CHECKSUMS_BUILD_VERSION} 
https://github.com/awslabs/aws-checksums/archive/${ARROW_AWS_CHECKSUMS_BUILD_VERSION}.tar.gz";
+  "ARROW_AWS_C_EVENT_STREAM_URL 
aws-c-event-stream-${ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION} 
https://github.com/awslabs/aws-c-event-stream/archive/${ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION}.tar.gz";
   "ARROW_AWSSDK_URL aws-sdk-cpp-${ARROW_AWSSDK_BUILD_VERSION}.tar.gz 
https://github.com/aws/aws-sdk-cpp/archive/${ARROW_AWSSDK_BUILD_VERSION}.tar.gz";

Review comment:
       ```suggestion
     "ARROW_AWSSDK_URL aws-sdk-cpp-${ARROW_AWSSDK_BUILD_VERSION}.tar.gz 
https://github.com/aws/aws-sdk-cpp/archive/${ARROW_AWSSDK_BUILD_VERSION}.tar.gz";
     "ARROW_AWS_CHECKSUMS_URL 
aws-checksums-${ARROW_AWS_CHECKSUMS_BUILD_VERSION} 
https://github.com/awslabs/aws-checksums/archive/${ARROW_AWS_CHECKSUMS_BUILD_VERSION}.tar.gz";
       "ARROW_AWS_C_COMMON_URL 
aws-c-common-${ARROW_AWS_C_COMMON_BUILD_VERSION}.tar.gz 
https://github.com/awslabs/aws-c-common/archive/${ARROW_AWS_C_COMMON_BUILD_VERSION}.tar.gz";
     "ARROW_AWS_C_EVENT_STREAM_URL 
aws-c-event-stream-${ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION} 
https://github.com/awslabs/aws-c-event-stream/archive/${ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION}.tar.gz";
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org