lidavidm commented on a change in pull request #10721:
URL: https://github.com/apache/arrow/pull/10721#discussion_r672252338
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -1930,29 +1930,23 @@ TEST(Cast, DictTypeToAnotherDict) {
check_cast(dictionary(int32(), utf8()), dictionary(int8(), utf8()),
R"(["a", "b", "a", null])");
+ // check float types (NOTE: ArrayFromJSON doesnt work for float value
dictionary types)
Review comment:
What was the error here? Would be nice to file a JIRA for it
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -1930,7 +1930,7 @@ TEST(Cast, DictTypeToAnotherDict) {
check_cast(dictionary(int32(), utf8()), dictionary(int8(), utf8()),
R"(["a", "b", "a", null])");
- // check float types (NOTE: ArrayFromJSON doesnt work for float value
dictionary types)
+ // check float types (TODO: ARROW-13381 ArrayFromJSON doesnt work for float
value dictionary types)
Review comment:
```suggestion
// check float types
// TODO(ARROW-13381): ArrayFromJSON doesnt work for float value dictionary
types
```
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -1930,7 +1930,7 @@ TEST(Cast, DictTypeToAnotherDict) {
check_cast(dictionary(int32(), utf8()), dictionary(int8(), utf8()),
R"(["a", "b", "a", null])");
- // check float types (NOTE: ArrayFromJSON doesnt work for float value
dictionary types)
+ // check float types (TODO: ARROW-13381 ArrayFromJSON doesnt work for float
value dictionary types)
Review comment:
Needs to be linted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
