westonpace commented on a change in pull request #10717:
URL: https://github.com/apache/arrow/pull/10717#discussion_r672525066
##########
File path: python/pyarrow/ipc.pxi
##########
@@ -158,9 +160,14 @@ cdef class IpcWriteOptions(_Weakrefable):
def compression(self, value):
if value is None:
self.c_options.codec.reset()
- else:
+ elif isinstance(value, str):
self.c_options.codec = shared_ptr[CCodec](GetResultValue(
CCodec.Create(_ensure_compression(value))).release())
+ elif isinstance(value, Codec):
+ self.c_options.codec = (<Codec>value).wrapped
Review comment:
There already was an `unwrap()` but it returned `CCodec*` and not
`shared_ptr<CCoded>`. I think I'd need to investigate where the current
`unwrap()` was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
