nirandaperera edited a comment on pull request #10585: URL: https://github.com/apache/arrow/pull/10585#issuecomment-883412386
> It would be a before vs after benchmark not side by side I tested this with the `ArraySortIndicesBool` benchmark and didn't see any significant difference in performance. So I think its okay to leave it with int64_t. ``` int64_t ------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... ------------------------------------------------------------------------------------------- ArraySortIndicesBool/32768/10000 856525 ns 790696 ns 1067 bytes_per_second=39.5221M/s items_per_second=331.536M/s null_percent=0.01 size=32.768k ArraySortIndicesBool/32768/100 1068125 ns 1067932 ns 644 bytes_per_second=29.2622M/s items_per_second=245.469M/s null_percent=1 size=32.768k ArraySortIndicesBool/32768/10 1322777 ns 1320088 ns 523 bytes_per_second=23.6727M/s items_per_second=198.581M/s null_percent=10 size=32.768k ArraySortIndicesBool/32768/2 1898999 ns 1871787 ns 372 bytes_per_second=16.6953M/s items_per_second=140.05M/s null_percent=50 size=32.768k ArraySortIndicesBool/32768/1 228503 ns 218945 ns 3266 bytes_per_second=142.73M/s items_per_second=1.19731G/s null_percent=100 size=32.768k ArraySortIndicesBool/32768/0 755168 ns 735851 ns 960 bytes_per_second=42.4678M/s items_per_second=356.246M/s null_percent=0 size=32.768k ArraySortIndicesBool/1048576/100 35812425 ns 35626885 ns 19 bytes_per_second=28.0687M/s items_per_second=235.457M/s null_percent=1 size=1048.58k ArraySortIndicesBool/8388608/100 320588616 ns 320491041 ns 2 bytes_per_second=24.9617M/s items_per_second=209.394M/s null_percent=1 size=8.38861M int32_t ------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... ------------------------------------------------------------------------------------------- ArraySortIndicesBool/32768/10000 768462 ns 763410 ns 1005 bytes_per_second=40.9347M/s items_per_second=343.385M/s null_percent=0.01 size=32.768k ArraySortIndicesBool/32768/100 1060476 ns 1026142 ns 765 bytes_per_second=30.4539M/s items_per_second=255.466M/s null_percent=1 size=32.768k ArraySortIndicesBool/32768/10 1447835 ns 1375450 ns 499 bytes_per_second=22.7198M/s items_per_second=190.588M/s null_percent=10 size=32.768k ArraySortIndicesBool/32768/2 2002536 ns 2001982 ns 343 bytes_per_second=15.6095M/s items_per_second=130.942M/s null_percent=50 size=32.768k ArraySortIndicesBool/32768/1 274177 ns 268186 ns 2750 bytes_per_second=116.523M/s items_per_second=977.469M/s null_percent=100 size=32.768k ArraySortIndicesBool/32768/0 735371 ns 734928 ns 1025 bytes_per_second=42.5211M/s items_per_second=356.693M/s null_percent=0 size=32.768k ArraySortIndicesBool/1048576/100 42704206 ns 42695362 ns 12 bytes_per_second=23.4217M/s items_per_second=196.476M/s null_percent=1 size=1048.58k ArraySortIndicesBool/8388608/100 310066885 ns 310040314 ns 2 bytes_per_second=25.8031M/s items_per_second=216.452M/s null_percent=1 size=8.38861M ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
