pitrou commented on a change in pull request #10752:
URL: https://github.com/apache/arrow/pull/10752#discussion_r674043575
##########
File path: cpp/src/arrow/csv/column_decoder.cc
##########
@@ -52,10 +51,12 @@ class ConcreteColumnDecoder : public ColumnDecoder {
// XXX useful?
virtual std::shared_ptr<DataType> type() const = 0;
- Status WrapConversionError(const Status& st) {
- if (st.ok()) {
- return st;
+ inline Result<std::shared_ptr<Array>> WrapConversionError(
Review comment:
No need to add `inline` here, it is implied when a method definition is
inside the `class` declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
