nevi-me commented on a change in pull request #491:
URL: https://github.com/apache/arrow-rs/pull/491#discussion_r674618144



##########
File path: parquet/src/arrow/arrow_reader.rs
##########
@@ -668,4 +668,20 @@ mod tests {
             batch.unwrap();
         }
     }
+
+    #[test]
+    fn test_read_maps() {
+        let testdata = arrow::util::test_util::parquet_test_data();
+        let path = format!("{}/nested_maps.snappy.parquet", testdata);
+        let parquet_file_reader =
+            
SerializedFileReader::try_from(File::open(&path).unwrap()).unwrap();
+        let mut arrow_reader = 
ParquetFileArrowReader::new(Arc::new(parquet_file_reader));
+        let record_batch_reader = arrow_reader
+            .get_record_reader(60)
+            .expect("Failed to read into array!");
+
+        for batch in record_batch_reader {
+            batch.unwrap();

Review comment:
       This is a bit tricky @alamb, because there's no output data to compare 
what's read to. The parquet test data that's used by parquet-mr, parquet-cpp 
and parquet-rs don't have equivalent JSON files like other integration tests.
   
   So, the next best thing has been to read the files, and confirm that the 
reader doesn't error out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to