lvheyang commented on a change in pull request #764:
URL: https://github.com/apache/arrow-datafusion/pull/764#discussion_r674848659
##########
File path: datafusion/src/physical_optimizer/pruning.rs
##########
@@ -399,40 +406,63 @@ impl<'a> PruningExpressionBuilder<'a> {
Ok(Self {
column,
column_expr,
+ op: correct_operator,
scalar_expr,
field,
required_columns,
- reverse_operator,
})
}
- fn correct_operator(&self, op: Operator) -> Operator {
- if !self.reverse_operator {
- return op;
- }
-
- match op {
- Operator::Lt => Operator::Gt,
- Operator::Gt => Operator::Lt,
- Operator::LtEq => Operator::GtEq,
- Operator::GtEq => Operator::LtEq,
- _ => op,
- }
+ fn op(&self) -> Operator {
+ self.op
}
fn scalar_expr(&self) -> &Expr {
- self.scalar_expr
+ &self.scalar_expr
}
fn min_column_expr(&mut self) -> Result<Expr> {
self.required_columns
- .min_column_expr(&self.column, self.column_expr, self.field)
+ .min_column_expr(&self.column, &self.column_expr, self.field)
}
fn max_column_expr(&mut self) -> Result<Expr> {
self.required_columns
- .max_column_expr(&self.column, self.column_expr, self.field)
+ .max_column_expr(&self.column, &self.column_expr, self.field)
+ }
+}
+
+fn rewrite_expr_to_prunable(
+ column_expr: &Expr,
+ op: Operator,
+ scalar_expr: &Expr,
+) -> Result<(Expr, Operator, Expr)> {
Review comment:
I've committed some simple cases in this file. Besides of them, I'm
still working on e2e test cases in tests/parquet_pruning.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
