jonkeane commented on a change in pull request #10780: URL: https://github.com/apache/arrow/pull/10780#discussion_r675054938
########## File path: r/R/alchemize.R ########## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#' Transform a data structure from one engine to another Review comment: Oh, yeah that's not too far off of what `tbl()` is used for elsewhere both `collect()` and `compute()` imply that there's a data processing/change step, where as `tbl()` doesn't have that same baggage. `tbl()` is a bit funny as it stands: [with `tbl.src_dbi()`](https://github.com/tidyverse/dbplyr/blob/47e53ce30402d41ae4b38c803de12e63d64a9b6c/R/src_dbi.R#L83-L86) takes a `src` (connection), and `from` a character of the table name versus the standard `tbl` from dplyr where the `src` argument is the thing you want to create a `tbl` from. Which would make our `tbl.*()` funny in that it has arguments: `src` - the Arrow object, `con` - the db connection to use, and `name` (or something like it, or maybe we embed that inside the function...) – the name of the view to create. I think for now this is fine (though I will try and make sure that the docs explain the funny bit where _for arrow -> duckdb_ the `src` in `tbl` is *not* the duckdb dbi connection like one might expect (and instead there's a con argument for that) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
