wjones127 commented on a change in pull request #8844:
URL: https://github.com/apache/arrow/pull/8844#discussion_r606018511
##########
File path: cpp/src/gandiva/like_holder.cc
##########
@@ -62,39 +56,95 @@ const FunctionNode LikeHolder::TryOptimize(const
FunctionNode& node) {
return node;
}
+const FunctionNode SQLLikeHolder::TryOptimize(const FunctionNode& node) {
Review comment:
`like` will now always optimize into `regexp_matches` or one of the
optimizations above. I found this to be the easiest way to reuse the
optimization code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
