JohanMabille commented on pull request #10712: URL: https://github.com/apache/arrow/pull/10712#issuecomment-886491384
Hi, @pitrou I think redefining the enums this way is counter intuitive for regular C++ programmers (at least it is for me, and I am used to hard core metaprogramming). Even if it removes some boilerplate, the complexity it adds to such a basic concept does not seem to be worth it (and besides it is less efficient than a traditional enum, although this might not be relevant here). A traditional approach of enum class and operators overloading would be more "standard". Providing a traits mechanism or equivalent that users *can* use to implement these operators is a nice to have but should not be the only way to plug addtitional enums in the system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
